feat: Custom authorization failure handler #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an option to the http.WithHeaderAuthorization middleware to modify the default response in case of authentication failure.
gkats
force-pushed
the
core-2073-custom-failure-middleware
branch
from
c5ecf74 to
ea2b482
Compare
| kid := "kid-" + t.Name() | ||
| // Mock the Clerk API server. We expect requests to GET /jwks. | ||
| clerkAPI := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| if r.URL.Path == "/jwks" && r.Method == http.MethodGet { |
There was a problem hiding this comment.
❓ Shouldn't the path here be "/v1/jwks"? 🤔
There was a problem hiding this comment.
API versioning is now determined by a header or query string parameter.
As a result, adding the version in the path has no effect and might change in the future.
We decided to think of "v1" as part of the API's base URL, since in the future API endpoint paths are likely to omit it.
There was a problem hiding this comment.
Resolved offline, the test Client is not configured with the v1/ path prefix, so this is the request path it accesses.
georgepsarakis
approved these changes
Apr 16, 2024
| kid := "kid-" + t.Name() | ||
| // Mock the Clerk API server. We expect requests to GET /jwks. | ||
| clerkAPI := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| if r.URL.Path == "/jwks" && r.Method == http.MethodGet { |
There was a problem hiding this comment.
Resolved offline, the test Client is not configured with the v1/ path prefix, so this is the request path it accesses.
Merged
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to the http.WithHeaderAuthorization middleware to modify the default response in case of authentication failure.
Fixes #277.